Add attrs to partial gran spans & tracking metrics #1608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmstepanek
force-pushed
the
add-error-attr-support
branch
from
29ea8dd to
dca5328
Compare
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts
|
hmstepanek
changed the title
hmstepanek
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop-hybrid-core-tracing #1608 +/- ##
==============================================================
Coverage ? 79.81%
==============================================================
Files ? 213
Lines ? 25105
Branches ? 3992
==============================================================
Hits ? 20038
Misses ? 3639
Partials ? 1428 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hmstepanek
commented
Dec 19, 2025
| # If the span is an exit span and we are in reduced mode (meaning no attribute dropping), | ||
| # just return the exit span as is. | ||
| if partial_granularity_type == "reduced": | ||
| ct_exit_spans["kept"] += 1 |
Contributor
Author
There was a problem hiding this comment.
There was a bug here that I fixed which is why this is here now. I had to move these into here because gets incremented multiple times if it's put in span_events because span_events loops over the children and then the children of the children (so it gets incremented multiple times each time is yields the node up the chain) where as here it is guaranteed that it is only incremented once.
hmstepanek
force-pushed
the
add-error-attr-support
branch
from
904321d to
ed87ffa
Compare
lrafeei
approved these changes
Dec 22, 2025
hmstepanek
merged commit 48eecd9
into
develop-hybrid-core-tracing
43 of 61 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
nr.idsin compact mode.nr.pgto entry span to track when a transaction is partial granularity.not a==b=>a!=b).